Move end to end tests to own crate #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
force-pushed
the
e2e-tests
branch
2 times, most recently
from
f26593f to
c7eea6b
Compare
hug-dev
reviewed
Apr 27, 2020
There was a problem hiding this comment.
Thanks a lot, that makes much more sense and leave us the option of doing real integration testing on our modules 😉
I like the "end-to-end" naming! Make it clear and separate it nicely from integration testing in tests/.
I am sure it will speed up our tests as well.
Comment on lines
+1
to
+3
| # This crate should NOT be upstreamed to crates.io; it is only intended for | ||
| # PARSEC testing purposes (both locally and on CI) | ||
| [package] |
There was a problem hiding this comment.
| picky-asn1 = "0.2.1" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| sha2 = "0.8.1" | ||
| parsec-client = { version = "0.2.0", features = ["testing"] } |
There was a problem hiding this comment.
👏 Nice not to have to add the interface next to that!
| @@ -63,12 +63,11 @@ while [ "$#" -gt 0 ]; do | |||
| error_msg "Only one provider name must be given" | |||
| fi | |||
| PROVIDER_NAME=$1 | |||
| CONFIG_PATH="e2e_tests/provider_cfg/$1/config.toml" | |||
hug-dev
approved these changes
Apr 27, 2020
This commit moves the PARSEC end-to-end tests into their own crate and refactors the test script along with it. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the PARSEC end-to-end tests into their own crate and
refactors the test script along with it.
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com
Fixes #155