Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PKCS11 tests to fail on Travis #154

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

ionut-arm
Copy link
Member

This commit adds a provision for Travis CI to allow it to fail for
PKCS11 tests.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

@ionut-arm ionut-arm added the bug Something isn't working label Apr 22, 2020
@ionut-arm ionut-arm added this to the Parsec production ready milestone Apr 22, 2020
@ionut-arm ionut-arm requested a review from hug-dev April 22, 2020 14:58
@ionut-arm ionut-arm self-assigned this Apr 22, 2020
@hug-dev
Copy link
Member

hug-dev commented Apr 22, 2020

cc #116

@hug-dev
Copy link
Member

hug-dev commented Apr 22, 2020

Did it trigger the PKCS 11 build at all?

@ionut-arm
Copy link
Member Author

Did it trigger the PKCS 11 build at all?

Hmm, it doesn't look like it.

.travis.yml Outdated
- DOCKER_IMAGE_NAME=mbed-crypto-provider
- DOCKER_IMAGE_PATH=tests/per_provider/provider_cfg/mbed-crypto
# Stress test fails on Travis CI, see #116
- SCRIPT="tests/ci.sh --no-stress-test mbed-crypto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the --no-stress-test and put them in the allow_failures if they start failing consistently

@ionut-arm ionut-arm force-pushed the disable-travis branch 3 times, most recently from 4c83d8c to 4715f9b Compare April 24, 2020 09:34
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked!

This commit adds a provision for Travis CI to allow it to fail for
PKCS11 tests.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm ionut-arm merged commit ba6c651 into parallaxsecond:master Apr 24, 2020
@ionut-arm ionut-arm deleted the disable-travis branch April 24, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants