Basic fuzzing harness #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would appreciate a double check of the |
DaniPopes
reviewed
Nov 18, 2024
There was a problem hiding this comment.
This target is redundant since the canonicalize function is implemented using the standard library, and it's also coming from dunce, not implemented here.
|
|
||
| let _ = sess.enter(|| -> solar_interface::Result<()> { | ||
| let mut pcx = solar_sema::ParsingContext::new(&sess); | ||
| pcx.load_file(&path).unwrap(); |
There was a problem hiding this comment.
We can avoid the temp file by using add_file with a SourceFile created in memory, like so:
let Ok(data) = std::str::::from_utf8(data) else {
return Ok(());
};
let Ok(file) = sess.source_map().new_dummy_source_file("fuzz".into(), data.to_string()) else {
return;
};
pcx.add_file(file);| solar-parse = { path = "../crates/parse" } | ||
| solar-interface = { path = "../crates/interface" } | ||
| solar-sema = { path = "../crates/sema" } | ||
| solar-cli = { path = "../crates/cli" } |
There was a problem hiding this comment.
Use .workspace = true instead for these dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic fuzzing harness to Solar using
cargo-fuzz, a popular frontend to thelibfuzzerfuzzing engine.Specifically, this PR contains the following cases:
run_compiler_args, a (reasonably close to) end-to-end case for the entire compilerparsing_context_parse_and_resolve, specifically targeting just parsing and semantic analysiscanonicalize, targeting path canonicalisation (low-hanging and likely uninteresting, but added for posterity)The intent (and expectation) is that this PR will allow for easy extension and expansion of fuzzing cases as development of the compiler progresses.