Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trie): move PrefixSetLoader to db crate #9985

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore(trie): move PrefixSetLoader to db crate #9985

merged 1 commit into from
Aug 1, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Aug 1, 2024 •
edited
Loading

Description

Supersedes #9970. Moves PrefixSetLoader from reth-trie to reth-trie-db. See #9970 (comment).

@rkrasiuk rkrasiuk requested a review from Rjected as a code owner August 1, 2024 13:05
@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Aug 1, 2024
@rkrasiuk rkrasiuk enabled auto-merge August 1, 2024 13:09
@RomanHodulak
Copy link
Contributor

Hey @rkrasiuk thanks for the review on #9970 .

There must be some mistake. I have not touched PrefixSetLoader and these changes do not seem related. How does this supersede #9970 ?

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 1, 2024
@rkrasiuk rkrasiuk mentioned this pull request Aug 1, 2024
Closed
@rkrasiuk
Copy link
Member Author

rkrasiuk commented Aug 1, 2024

responded here #9970 (comment)

Merged via the queue into main with commit de0bbb4 Aug 1, 2024
33 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/move-prefixset-loader-to-db-crate branch August 1, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @RomanHodulak @mattsse