Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(net): Remove dependency reth-network-p2p -> reth-network-types #9984

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore(net): Remove dependency reth-network-p2p -> reth-network-types #9984

merged 1 commit into from
Aug 1, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 1, 2024 •
edited
Loading

Moves reth_network_types::reputation to reth_network_p2p::reputation. This unlocks the possibility to move reth_network::FullNetwork trait into reth-network-api.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-networking Related to networking in general labels Aug 1, 2024
@emhane emhane enabled auto-merge August 1, 2024 12:59
@emhane emhane added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit e95ec4c Aug 1, 2024
34 checks passed
@emhane emhane deleted the emhane/move-reputation-to-p2p branch August 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse