feat: combine block writing in persistence task #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jul 31, 2024
onbjerg
approved these changes
Aug 1, 2024
joshieDo
reviewed
Aug 1, 2024
| &self, | ||
| blocks: &[ExecutedBlock], | ||
| provider_rw: &DatabaseProviderRW<DB>, | ||
| static_file_provider: &StaticFileProvider, |
There was a problem hiding this comment.
I guess for consistency... but it shouldn't be needed, since it's a private method and can be taken from self. not strongly opinated
joshieDo
approved these changes
Aug 1, 2024
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we just need to commit in a specific order, this combines all the existing writing methods that were called when handling
SaveBlocks.