Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set pending block in canonical memory #9950

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat: set pending block in canonical memory #9950

merged 1 commit into from
Jul 31, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2024

closes #9829

if the freshly executed block has the canonical head as the parent block, we can insert it as the pending block

@mattsse mattsse added the C-enhancement New feature or request label Jul 31, 2024
Rjected
Rjected approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse enabled auto-merge July 31, 2024 16:44
@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit d571637 Jul 31, 2024
33 checks passed
@mattsse mattsse deleted the matt/update-pending-block branch July 31, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pending block if new
2 participants
@mattsse @Rjected