Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improving docs from TestBlockBuilder #9936

Merged
merged 2 commits into from
Jul 31, 2024
Merged

docs: improving docs from TestBlockBuilder #9936

merged 2 commits into from
Jul 31, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jul 31, 2024 •
edited
Loading

Relates to #9925

fgimenez
fgimenez reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! smol nit in one of the method docs

crates/chain-state/src/test_utils.rs Outdated Show resolved Hide resolved
@mvares mvares requested a review from fgimenez July 31, 2024 14:41
@mattsse mattsse added the C-docs An addition or correction to our documentation label Jul 31, 2024
@fgimenez fgimenez enabled auto-merge July 31, 2024 14:51
@fgimenez fgimenez added this pull request to the merge queue Jul 31, 2024
Merged via the queue into paradigmxyz:main with commit d16ec0d Jul 31, 2024
32 checks passed
@mvares mvares deleted the 2024-06-31 branch August 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvares @fgimenez @mattsse