Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pick safe hash for initial download #9934

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2024

adds a few more traces and ports a previous check to pick the download target,
if this is the first FCU we download the head block first so we need to download fewer blocks before we can trigger backfill

@mattsse mattsse added the C-perf A change motivated by improving speed, memory usage or disk footprint label Jul 31, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nit about one of the comments

crates/engine/tree/src/tree/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
@mattsse mattsse enabled auto-merge July 31, 2024 14:20
@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 8dfaf6c Jul 31, 2024
32 checks passed
@mattsse mattsse deleted the matt/pick-safe-block-to-download-first branch July 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants