Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle insert buffered block err gracefully #9933

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat: handle insert buffered block err gracefully #9933

merged 1 commit into from
Jul 31, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2024

buffering a block could also fail if the block is malformed.

extracts the error handling function

@mattsse mattsse added the C-enhancement New feature or request label Jul 31, 2024
fgimenez
fgimenez approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 263be9c Jul 31, 2024
33 checks passed
@mattsse mattsse deleted the matt/handle-insert-buffer-error branch July 31, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @fgimenez