chore: refactor BlockExecutionError into validation and internal errors #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
requested review from
mattsse,
rakita,
onbjerg,
shekhirin and
rkrasiuk
as code owners
mattsse
approved these changes
Jul 30, 2024
Rjected
force-pushed
the
dan/refactor-block-execution-error
branch
from
4d8e44c
to
8154dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a variant that is specific to non-validation-related execution errors. This way, we can use it in other error types, for example in #9884 where we return an
INVALIDresponse for validation-related errors and can filter those variants outdepends on #9905