fix(engine): use provider to initialize persistence state #9785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
mattsse
requested changes
Jul 25, 2024
There was a problem hiding this comment.
hmm, should these be initialized with the current on disk head?
but I guess we can make these an option first until we have an initial persistence run?
reth/crates/engine/tree/src/tree/mod.rs
Lines 389 to 390 in 527cc44
yeah actually that would be better |
Rjected
force-pushed
the
dan/move-last-persisted-to-options
branch
from
6904cd0
to
e82a424
Compare
Rjected
changed the title
mattsse
approved these changes
Jul 25, 2024
|
failing test |
Previously, on node startup, these would be zero, making `should_persist` always true, also causing the engine to send empty blocks to `save_blocks`. Now these are options, which are only set when a persistence task finished. Otherwise, the start for any persistence distance measurement will be the minimum block stored in the tree.
Rjected
force-pushed
the
dan/move-last-persisted-to-options
branch
from
e82a424
to
885cdc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on node startup, these would be zero, making
should_persistalways true on startup, also causing the engine to send empty blocks tosave_blocks.Now these are initialized using values from the provider factory, which should correspond to the values that are actually on-disk.