feat: integrate BlockchainProvider2 in EthNodeLauncher #9754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9731
There were some references to the concrete type
BlockchainProvider
in the launcher types, this is now generic overT::Provider
.Also, in the
with_blockchain_db
method, we need to instantiate the concrete blockchain provider, and the constructors are different forBlockchainProvider
andBlockchainProvider2
, the latter doesn't take aTreeViewer
. Now this is implemented with a closure and the need to create a tree instance outside the ctx methods, once the migration is done this will be simplified.