feat(exex): backfill stream in batches #9738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
requested review from
onbjerg,
rakita,
mattsse and
Rjected
as code owners
mattsse
requested changes
Jul 30, 2024
Comment on lines
+112
to
+118
| // Take the next `batch_size` blocks from the range and calculate the range bounds | ||
| let mut range = this.range.by_ref().take(this.batch_size); | ||
| let start = range.next(); | ||
| let range_bounds = start.zip(range.last().or(start)); | ||
|
|
||
| // Advance the range by `batch_size` blocks | ||
| this.range.nth(this.batch_size); |
There was a problem hiding this comment.
this will run a few times but should be negligible overhead but range could be wrapped into Peekable and integrated into while condition
but it looks like this is just
https://docs.rs/itertools/latest/itertools/trait.Itertools.html#method.chunks
There was a problem hiding this comment.
using itertools' chunks will require having a lifetime on the struct and also storing the original iterator in a field. We can also do (0..batch_size).map_while(|_| this.range.next()) here, but it's more expensive than doing nth just once.
Didn't get your idea with peekable.
shekhirin
force-pushed
the
alexey/backfill-stream-batch
branch
from
6869a98
to
46ebfe7
Compare
mattsse
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9735