Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add storage_root provider function for account #9659

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat : add storage_root provider function for account #9659

merged 4 commits into from
Aug 2, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Jul 19, 2024

closes #9643

@nkysg nkysg marked this pull request as draft July 19, 2024 17:30
@nkysg nkysg marked this pull request as ready for review July 20, 2024 03:52
@nkysg nkysg changed the title feat : Add storage_root provider function for account feat : add storage_root provider function for account Jul 20, 2024
@rkrasiuk rkrasiuk mentioned this pull request Jul 20, 2024
Merged
@mattsse mattsse enabled auto-merge July 20, 2024 12:25
@mattsse mattsse disabled auto-merge July 20, 2024 12:25
@nkysg nkysg requested a review from mattsse July 26, 2024 01:55
mattsse
mattsse requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the conflicts @nkysg there's currently some movement

but otherwise this looks good

ptal @rkrasiuk

@nkysg nkysg force-pushed the storage_root branch 3 times, most recently from 4a7b4fb to a88f16f Compare July 27, 2024 01:51
@nkysg nkysg closed this Jul 27, 2024
@nkysg nkysg deleted the storage_root branch July 27, 2024 04:17
@nkysg nkysg restored the storage_root branch July 27, 2024 04:17
@nkysg nkysg reopened this Jul 27, 2024
@nkysg nkysg closed this Jul 27, 2024
@nkysg nkysg reopened this Jul 27, 2024
@nkysg
Copy link
Contributor Author

nkysg commented Jul 27, 2024 •
edited
Loading

Thanks for your helps @mattsse @rkrasiuk . Update PR.

mattsse
mattsse approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @rkrasiuk

@nkysg
Copy link
Contributor Author

nkysg commented Aug 1, 2024

PLTL @rkrasiuk .Thanks.

nkysg and others added 3 commits August 2, 2024 08:08
@nkysg @rkrasiuk
Add storage_root provider function for account
749718e 
update StateRootProvider::storage_root_from_range

fix doc

fix comment

remove unused code

update HashedStorage trait
@nkysg @rkrasiuk
fix rebase update
8e9a60a
@rkrasiuk
fix interface
684d664
@rkrasiuk rkrasiuk enabled auto-merge August 2, 2024 07:05
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 2, 2024
Merged via the queue into paradigmxyz:main with commit 4402807 Aug 2, 2024
32 checks passed
@nkysg nkysg deleted the storage_root branch August 2, 2024 07:40
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@nkysg @rkrasiuk @martinezjorge
feat : add storage_root provider function for account (paradigmxyz#9659)
a24fe5b 
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add storage_root provider function for account
3 participants
@nkysg @mattsse @rkrasiuk