Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarify TransitionConfigurationExchanged event #9647

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore: clarify TransitionConfigurationExchanged event #9647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/consensus/beacon/src/engine/handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ where
/// Sends a transition configuration exchange message to the beacon consensus engine.
///
/// See also <https://github.com/ethereum/execution-apis/blob/3d627c95a4d3510a8187dd02e0250ecb4331d27e/src/engine/paris.md#engine_exchangetransitionconfigurationv1>
///
/// This only notifies about the exchange. The actual exchange is done by the engine API impl
/// itself.
pub fn transition_configuration_exchanged(&self) {
let _ = self.to_engine.send(BeaconEngineMessage::TransitionConfigurationExchanged);
}
Expand Down
3 changes: 2 additions & 1 deletion crates/engine/tree/src/tree/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,8 @@ where
}
}
BeaconEngineMessage::TransitionConfigurationExchanged => {
todo!()
// this is a reporting no-op because the engine API impl does not need
// additional input to handle this request
}
},
FromEngine::DownloadedBlocks(blocks) => {
Expand Down
Loading