Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move canon state types to new module #9613

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 18, 2024

moves state types to a new module

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 18, 2024

/// State after applying the given block.
#[derive(Debug, PartialEq, Eq, Clone)]
pub struct BlockState(pub(crate) ExecutedBlock);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name makes more sense 👍

pub(crate) fn receipts(&self) -> &Receipts {
&self.0.execution_outcome().receipts
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are tests we can move here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, will check next

@mattsse mattsse added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit b1d62b1 Jul 18, 2024
33 checks passed
@mattsse mattsse deleted the matt/move-state-types branch July 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants