Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom provider type #9606

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 18, 2024

adds a way to customize the provider type we're using in NodeBuilder,

this will come in handy when we implement the new engine design that also requires changes to the underlying provider

this can be restricted during launch like:

T: FullNodeTypes<Provider = BlockchainProvider<<T as FullNodeTypes>::DB>>,

FYI @fgimenez

this way we can roll a new BlockchainProvider type without modifying the existing one and simply duplicate it for the time being

@mattsse mattsse added the C-enhancement New feature or request label Jul 18, 2024
@mattsse mattsse requested a review from fgimenez July 18, 2024 11:53
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@mattsse mattsse added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit ea47939 Jul 18, 2024
33 checks passed
@mattsse mattsse deleted the matt/allow-custom-provider-in-node-builder branch July 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants