feat(trie): add empty reth-trie-db crate
#9585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
approved these changes
Jul 18, 2024
rkrasiuk
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR is one of a series of small PRs comprising #9282
Motivation
Extending #9282 , the resulting PR is way too large for inclusion and while it implements one refactor, it is separable into tiny atomic PR within this large context.
Goals
Create an empty crate where the database dependencies from
reth-triewill be separated into. Filling the crate with relevant code is a concern of follow-up PRs.Solution
We're adding
reth-trie-dbinheriting workspace package information but with no dependencies.Additional notes
Perhaps this PR might be too small, because it only serves as a groundwork for the follow-up PRs, it does not add any value besides that. However, it is done on the suggestion of reviewers and I believe it makes sense in the broader context. The benefits of working with smaller PRs are that we can better focus on these small changes and include them more confidently.