Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(evm): remove unneeded lifetimes #9583

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore(evm): remove unneeded lifetimes #9583

merged 2 commits into from
Jul 17, 2024

Conversation

shekhirin
Copy link
Collaborator

I don't think we need them on self

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-execution Related to the Execution and EVM labels Jul 17, 2024
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if this works

@shekhirin shekhirin marked this pull request as ready for review July 17, 2024 13:23
@shekhirin shekhirin enabled auto-merge July 17, 2024 13:23
@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@shekhirin shekhirin enabled auto-merge July 17, 2024 14:12
@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 269c649 Jul 17, 2024
33 checks passed
@shekhirin shekhirin deleted the alexey/evm-lifetimes branch July 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse