Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): move OpEthApi traits into reth-optimism-rpc #9581

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore(rpc): move OpEthApi traits into reth-optimism-rpc #9581

merged 1 commit into from
Jul 17, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 17, 2024

Removes optimism feature from reth-rpc-api, by moving OP traits into reth-optimism-rpc.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 17, 2024
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emhane emhane enabled auto-merge July 17, 2024 13:03
@emhane emhane added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 0630621 Jul 17, 2024
34 checks passed
@emhane emhane deleted the emhane/move-op-ethapi branch July 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse