Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add in memory state container #9574

Merged
merged 3 commits into from
Jul 17, 2024
Merged

feat: add in memory state container #9574

merged 3 commits into from
Jul 17, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Jul 17, 2024 •
edited
Loading

Closes #8747

Follow up of #9518

  • Introduces InMemoryStateImpl as a state container. It is meant to keep only data related to the canonical chain, its updates will be implemented in the next PRs.
  • Added an instance of InMemoryStateImpl to EngineApiTreeHandlerImpl, the canonical in-memory state will be provided to external consumers from here instead of reusing state.tree_state
  • Added impl of InMemoryState for InMemoryStateImpl
  • Changes in State to provide the related block and Receipts, now it wraps an ExecutedBlock and obtains all the state info from it.
  • Unit tests for InMemoryStateImpl and State

@fgimenez fgimenez force-pushed the fgimenez/in-memory-state-container branch from 670e9ab to b6203c1 Compare July 17, 2024 11:39
@fgimenez fgimenez changed the title feat: add canonical in memory state container feat: add in memory state container Jul 17, 2024
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, one step closer

@mattsse mattsse added this pull request to the merge queue Jul 17, 2024
@mattsse mattsse added the C-enhancement New feature or request label Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@fgimenez fgimenez added this pull request to the merge queue Jul 17, 2024
Merged via the queue into paradigmxyz:main with commit 0994d36 Jul 17, 2024
33 checks passed
@fgimenez fgimenez deleted the fgimenez/in-memory-state-container branch July 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blockchain Provider tree state integration
2 participants
@fgimenez @mattsse