Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove serde support from reth-codec #9570

Merged
merged 4 commits into from
Jul 17, 2024
Merged

chore: remove serde support from reth-codec #9570

merged 4 commits into from
Jul 17, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Jul 17, 2024

closes #9558

mattsse
mattsse requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, one q

crates/storage/codecs/src/lib.rs
@@ -556,7 +557,7 @@ mod tests {
}

#[reth_codec]
#[derive(Debug, PartialEq, Clone)]
#[derive(Debug, PartialEq, Clone, Serialize, Deserialize)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this here?

Copy link
Contributor Author

@nkysg nkysg Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reth/crates/storage/codecs/src/lib.rs

Lines 621 to 623 in ffb44e6

#[test_fuzz::test_fuzz]
fn compact_test_enum_all_variants(var0: TestEnum, var1: TestEnum, var2: TestEnum) {
let mut buf = vec![];

This place needs to TestEnum Serialize, so TestStruct also needs.

crates/storage/codecs/src/lib.rs
@@ -608,7 +609,7 @@ mod tests {
}

#[reth_codec]
#[derive(Debug, PartialEq, Clone, Default)]
#[derive(Debug, PartialEq, Clone, Default, Serialize, Deserialize)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 17, 2024
@nkysg
chore: remove serde support from reth-codec
b71993d 
chore: remove serde support from reth-codec
@nkysg
Fixed
b2a5382
@nkysg nkysg force-pushed the remove_serde_from_reth_codec branch from aa7a3df to b2a5382 Compare July 17, 2024 10:59
@mattsse mattsse added this pull request to the merge queue Jul 17, 2024
Merged via the queue into paradigmxyz:main with commit 0befab5 Jul 17, 2024
32 checks passed
@nkysg nkysg deleted the remove_serde_from_reth_codec branch July 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove serde support from reth-codec
2 participants
@nkysg @mattsse