Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm outdated impls #9560

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore: rm outdated impls #9560

merged 1 commit into from
Jul 16, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 16, 2024

these are no longer required

@mattsse mattsse requested a review from Rjected as a code owner July 16, 2024 21:13
@mattsse mattsse requested review from onbjerg and removed request for Rjected July 16, 2024 21:13
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 16, 2024
Rjected
Rjected approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 4b8a66f Jul 16, 2024
33 checks passed
@mattsse mattsse deleted the matt/rm-outdated-impls branch July 16, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected