feat(pruner, stages): logs for Prune stage #9520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
changed the title
Prune stage logs
shekhirin
changed the title
shekhirin
added
C-enhancement
shekhirin
changed the title
shekhirin
requested review from
onbjerg,
rkrasiuk,
joshieDo,
mattsse,
Rjected and
fgimenez
as code owners
mattsse
approved these changes
Jul 15, 2024
Comment on lines
+14
to
+18
| impl From<PruneProgress> for PrunerOutput { | ||
| fn from(progress: PruneProgress) -> Self { | ||
| Self { progress, segments: Vec::new() } | ||
| } | ||
| } |
There was a problem hiding this comment.
can we do a new function for this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9515
The change itself is just this line
reth/crates/stages/stages/src/stages/prune.rs
Line 52 in 2dc3677
But I also needed to introduce a better output for the
Pruner::run, which required juggling the pruner types around two crates.