-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(op): remove optimism feature for LoadReceipts
#9504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try generic over EthApi
…lder until as late as possible
…api builder until as late as possible
emhane
added
C-debt
Refactor of code section that is hard to understand or maintain
A-rpc
Related to the RPC implementation
A-op-reth
Related to Optimism and op-reth
labels
Jul 15, 2024
emhane
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
July 15, 2024 09:43
mattsse
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
this is however blocked until we integrate OpEthApi
mattsse
added
the
S-blocked
This cannot more forward until something else changes
label
Jul 16, 2024
emhane
removed
the
S-blocked
This cannot more forward until something else changes
label
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the optimism feature gated
LoadReceipt
impl onEthApi
, since it now is implemented onOpEthApi
instead