Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(op): remove optimism feature for LoadReceipts #9504

Merged
merged 26 commits into from
Jul 16, 2024
Merged

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 15, 2024

Removes the optimism feature gated LoadReceipt impl on EthApi, since it now is implemented on OpEthApi instead

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 15, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

this is however blocked until we integrate OpEthApi

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jul 16, 2024
Base automatically changed from emhane/node-addons to main July 16, 2024 14:06
@emhane emhane removed the S-blocked This cannot more forward until something else changes label Jul 16, 2024
@emhane emhane enabled auto-merge July 16, 2024 14:52
@emhane emhane added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 16, 2024
@emhane emhane added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 4dbf47b Jul 16, 2024
33 checks passed
@emhane emhane deleted the emhane/op-load-receipt branch July 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants