Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(op): remove optimism feature from LoadPendingBlock #9503

Merged
merged 25 commits into from
Jul 16, 2024
Merged

chore(op): remove optimism feature from LoadPendingBlock #9503

merged 25 commits into from
Jul 16, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 15, 2024

Removes optimism feature from default LoadPendingBlock impl

mattsse and others added 24 commits July 10, 2024 14:45
@mattsse
feat: API scaffolding
0f89de1
@emhane
Merge branch 'main' into matt/builder3
758eaf4
@emhane
Add NodeAddOns generic to NodeComponentsBuilder
57de37f
@emhane
Move eth config and builder ctx to reth-rpc-eth-types & make RpcRegis…
1e94e8d 
…try generic over EthApi
@emhane
Remove NodeAddOnBuilders trait and defer instantiation of eth api bui…
a4115f2 
…lder until as late as possible
@emhane
fixup! Remove NodeAddOnBuilders trait and defer instantiation of eth …
28b7116 
…api builder until as late as possible
@emhane
Fix conflicts
a97ba95
@emhane
Fix lint for lib
5955c2c
@emhane
Fix docs
8008698
@emhane
Merge branch 'main' into emhane/node-addons
2ba7df9
@emhane
Plug-in OpEthApi to node builder
8dd44b5
@emhane
Fix lint remaining targets
4e5ad50
@emhane
Fix spelling
a90a55a
@emhane
fixup! Fix spelling
9f67cf1
@emhane
Enable optimism feature for reth-optimism-rpc in reth-node-optimism
c9a2a7c
@emhane
fixup! Enable optimism feature for reth-optimism-rpc in reth-node-opt…
dd96713 
…imism
@emhane
Fix doctests
31b8a12
@emhane
Merge branch 'main' into emhane/node-addons
64f5eee
@emhane
Remove unused trait
4c23365
@emhane
Remove redundant trait SpawnEthApi
86843a6
@emhane
Implement Call for OpEthApi
d726bab
@emhane
Remove optimism feature from LoadPendingBlock default impl
c726c41
@emhane
Remove optimism LoadPendingBlock impl for EthApi
68d5007
@emhane
Fix syntax
d7359ce
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 15, 2024
mattsse
mattsse approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

blocked until we integrate opethapi

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jul 16, 2024
Base automatically changed from emhane/op-ethapi-call to main July 16, 2024 15:32
@emhane emhane enabled auto-merge July 16, 2024 16:19
@emhane emhane added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 458251f Jul 16, 2024
33 checks passed
@emhane emhane deleted the emhane/op-ethapi-pending-block branch July 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@shekhirin shekhirin Awaiting requested review from shekhirin

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse