Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max_gas_limit to ChainSpec #9473

Merged
merged 5 commits into from
Jul 12, 2024
Merged

feat: add max_gas_limit to ChainSpec #9473

merged 5 commits into from
Jul 12, 2024

Conversation

joshieDo
Copy link
Collaborator

closes #3233

@joshieDo joshieDo added C-enhancement New feature or request A-consensus Related to the consensus engine labels Jul 12, 2024
@joshieDo joshieDo requested a review from gakonst as a code owner July 12, 2024 10:36
mattsse
mattsse requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/chainspec/src/spec.rs Outdated Show resolved Hide resolved
@joshieDo joshieDo enabled auto-merge July 12, 2024 10:51
@joshieDo joshieDo disabled auto-merge July 12, 2024 10:51
@mattsse mattsse added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit b4363e2 Jul 12, 2024
32 checks passed
@mattsse mattsse deleted the joshie/cspec branch July 12, 2024 14:26
@nkysg nkysg mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: allow configuring block gas limit through ChainSpec
2 participants
@joshieDo @mattsse