-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OP: keep encoded txs in payload attributes #9467
Merged
mattsse
merged 6 commits into
paradigmxyz:main
from
martinezjorge:op-keep-encoded-txs-in-payload-attributes
Jul 13, 2024
Merged
feat: OP: keep encoded txs in payload attributes #9467
mattsse
merged 6 commits into
paradigmxyz:main
from
martinezjorge:op-keep-encoded-txs-in-payload-attributes
Jul 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sactions to OptimismPayloadBuilderAttributes and updated try_new to store the encoded transactions
martinezjorge
changed the title
op: keep encoded txs in payload attributes
feat: OP: keep encoded txs in payload attributes
Jul 12, 2024
mattsse
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good start,
one suggestion to add a helper type for this because I assume this can useful for more use cases
mattsse
added
C-enhancement
New feature or request
A-op-reth
Related to Optimism and op-reth
labels
Jul 12, 2024
mattsse
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, tysm!
mattsse
force-pushed
the
op-keep-encoded-txs-in-payload-attributes
branch
from
July 13, 2024 05:06
a0c0a71
to
374b7fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes
I think the issue just wanted helper type added
Not sure if I'm jumping the gun with the following changes
Let me know if you want the last changes or if I'm doing something bad
closes #9422