Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OP: keep encoded txs in payload attributes #9467

Conversation

martinezjorge
Copy link
Contributor

@martinezjorge martinezjorge commented Jul 12, 2024

This PR has the following changes

I think the issue just wanted helper type added

  • Added OptimismPayloadBuilderAttributesHelper type

Not sure if I'm jumping the gun with the following changes

  • Added encoded-transactions to OptimismPayloadBuilderAttributes
  • Updated try_new to store the encoded transactions
  • Updated a test that relies on this

Let me know if you want the last changes or if I'm doing something bad

closes #9422

…sactions to OptimismPayloadBuilderAttributes and updated try_new to store the encoded transactions
@martinezjorge martinezjorge changed the title op: keep encoded txs in payload attributes feat: OP: keep encoded txs in payload attributes Jul 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start,
one suggestion to add a helper type for this because I assume this can useful for more use cases

crates/optimism/payload/src/payload.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/payload.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request A-op-reth Related to Optimism and op-reth labels Jul 12, 2024
@mattsse mattsse marked this pull request as ready for review July 12, 2024 09:29
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, tysm!

@mattsse mattsse force-pushed the op-keep-encoded-txs-in-payload-attributes branch from a0c0a71 to 374b7fa Compare July 13, 2024 05:06
@mattsse mattsse enabled auto-merge July 13, 2024 05:09
@mattsse mattsse added this pull request to the merge queue Jul 13, 2024
Merged via the queue into paradigmxyz:main with commit 67f6176 Jul 13, 2024
32 checks passed
@martinezjorge martinezjorge deleted the op-keep-encoded-txs-in-payload-attributes branch July 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op: keep encoded txs in payload attributes
2 participants