Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use DatabaseProviderRW on StateWriter::write_to_storage instead of TX #9449

Merged
merged 3 commits into from
Jul 11, 2024
Merged

chore: use DatabaseProviderRW on StateWriter::write_to_storage instead of TX #9449

merged 3 commits into from
Jul 11, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jul 11, 2024 •
edited
Loading

Forced to change a few others:

  • insert_genesis_state
  • insert_state

As well as changing a couple writer trait implementations from DatabaseProvider<DbTx + DbTxMut> to DatabaseProviderRW as it should

@joshieDo joshieDo added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database labels Jul 11, 2024
Rjected
Rjected approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@joshieDo joshieDo enabled auto-merge July 11, 2024 19:42
@joshieDo joshieDo added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 22df39a Jul 11, 2024
32 checks passed
@joshieDo joshieDo deleted the joshie/state-writer branch July 11, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @Rjected @mattsse