feat(rpc/admin): compatible with geth's admin_nodeInfo #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
requested changes
Jul 11, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
requested changes
Jul 12, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
approved these changes
Jul 16, 2024
mattsse
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, fixed two data inconsistent with geth's response of
admin_nodeInfo:idshould be the node's public key, wait for alloy to be released a new version, ref fix(admin): id in NodeInfo is string instead of B256 alloy-rs/alloy#1038protocols.eth.config, after this issue fixed, we can use reth to fetch the prestate to run trace tests and any other state-related testing, ref https://github.com/ethereum/go-ethereum/blob/2d9d42376436cd275c28056cffd0eb97cb8daed8/eth/tracers/internal/tracetest/makeTest.js#L30It's not clever to extract the xxxBlocks in the admin module, should be implement in chainspec instead.