Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace base fee constants with native const #9437

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: replace base fee constants with native const #9437

merged 1 commit into from
Jul 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 11, 2024

these were moved to alloy

base mainnet hase same params as op mainnet

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 11, 2024
@mattsse mattsse enabled auto-merge July 11, 2024 08:43
Rjected
Rjected approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, makes sense

@mattsse mattsse added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit f29fefb Jul 11, 2024
33 checks passed
@mattsse mattsse deleted the matt/rm-base-fee-constants branch July 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected