Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): reusable eth api EthCall #8683

Merged
merged 67 commits into from
Jun 11, 2024
Merged

chore(rpc): reusable eth api EthCall #8683

merged 67 commits into from
Jun 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jun 7, 2024 •
edited
Loading

  • Moves rpc call methods impl on EthApi, to default trait impl EthCall
  • Moves fee rpc methods impl on EthApi, to default trait impl EthFees

emhane added 30 commits June 1, 2024 12:18
@emhane
Make on_blocking_task method accessible in default trait method impls
cab888f
@emhane
Minimise thread interface eth api
b902f35
@emhane
Update docs and symbol name
c35b40e
@emhane
Add missing reth primitives to op feature
8ccddd3
@emhane
Remove feature gate to fix broken test
257dc5d
@emhane
Fix flaky test
40194d6
@emhane
fixup! Fix flaky test
68e64b4
@emhane
fixup! Fix flaky test
30b63cc
@emhane
Update lock file
fcc64ea
@emhane
Reinsert functions for spawning blocking threads into EthTransactions
734ac99
@emhane
Drive-by, update docs
c000f43
@emhane
Move spawn cpu heavy to trait
d1b91ad
@emhane
Fix lint
eec99b8
@emhane
Revert impl for spawning blocking io
924024f
@emhane
Make impl of spawn blocking default trait methods
ea6cbd3
@emhane
Update docs
ecb6771
@emhane
Revert unrelated changes
fe494dc
@emhane
Merge branch 'main' into emhane/blocking-read
ba6f403
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
55d2649
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
139f97f
@emhane
Fix lint
8b8ed16
@emhane
Add super traits to spawn blocking
f3ed6bd
@emhane
Move impl of methods using evm config to default trait methods
16334cd
@emhane
Move EthApi state access methods into trait
20d2489
@emhane
Move EthTransaction impls to default trait methods
4a40032
@emhane
Move state rpc methods into new trait default impl
f2df915
@emhane
fixup! Move state rpc methods into new trait default impl
ca19811
@emhane
Move EthTransactions impl to default trait methods
8ee373c
@emhane
Add trait for pending block
6dfac1a
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/ethapi-txns
90f67b6
emhane and others added 13 commits June 8, 2024 21:19
@emhane
Revert method name
024a61b
@emhane
fixup! Revert method name
d613ccd
@github-actions @github-merge-queue
chore(deps): weekly cargo update (#8697)
c1d69d3 
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
@mattsse
chore: rename network-types to network-peers (#8699)
2852893
@kamuik16 @mattsse
feat: remove Bandwidthmeter type (#8698)
c7fd507 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse
chore: replace secp256k1 with fully qualified path (#8701)
2216b4b
@mattsse
docs: improve custom-evm example docs (#8703)
da1536f
@joshieDo
feat: add storage consistency checks on CLI commands (#8667)
ab8b458
@mattsse
chore: move workspace.package to top of Cargo.toml (#8691)
40fc19f
@mattsse
feat: add launch_with_fn (#8694)
53f4eca
@mattsse
feat: add ExExLauncher (#8693)
ee7a829
@emhane
Merge branch 'main' into matt/scaffold-ethapi
9a38b37
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/ethapi-call
92c1750
mattsse
mattsse requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is coming together.

having a ton of traits can be overwhelming at first, but this makes a ton of sense here because the eth_api is massive, and dividing this in multiple traits makes sense, because this allows the consumer to reuse as much as possible from the ethapiinner and only reimplement necessary functions, right?

crates/storage/provider/src/traits/spec.rs Outdated Show resolved Hide resolved
crates/evm/src/provider.rs Outdated Show resolved Hide resolved
crates/optimism/rpc/src/block.rs Show resolved Hide resolved
crates/optimism/rpc/src/lib.rs Show resolved Hide resolved
crates/rpc/rpc/src/debug.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/debug.rs Outdated Show resolved Hide resolved
@emhane emhane requested a review from onbjerg as a code owner June 10, 2024 19:57
mattsse
mattsse approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a ton of changes are actually due to main rebase?

let's get this into the branch and then have a closer look.

I believe this is looking great and will be very useful

@emhane emhane merged commit f89077b into matt/scaffold-ethapi Jun 11, 2024
18 of 25 checks passed
@emhane emhane deleted the emhane/ethapi-call branch June 11, 2024 16:26
@emhane emhane mentioned this pull request Jun 12, 2024
Open
@emhane emhane mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst left review comments

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emhane @gakonst @mattsse @kamuik16 @joshieDo