Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit_into_iter_loop clippy lint #8569

Merged
merged 3 commits into from
Jun 3, 2024
Merged

add explicit_into_iter_loop clippy lint #8569

merged 3 commits into from
Jun 3, 2024

Conversation

tcoratger
Copy link
Contributor

No description provided.

shekhirin
shekhirin approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, @mattsse wdyt?

@shekhirin shekhirin added the C-debt Refactor of code section that is hard to understand or maintain label Jun 3, 2024
DaniPopes
DaniPopes approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l gtm

mattsse
mattsse approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@mattsse mattsse enabled auto-merge June 3, 2024 17:36
@mattsse mattsse added this pull request to the merge queue Jun 3, 2024
Merged via the queue into paradigmxyz:main with commit b686872 Jun 3, 2024
30 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@tcoratger @mw2000
add explicit_into_iter_loop clippy lint (paradigmxyz#8569)
f0a88d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoratger @shekhirin @mattsse @DaniPopes