Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump discv5 #7981

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: bump discv5 #7981

merged 1 commit into from
Aug 28, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Apr 30, 2024

Bumps discv5 and removes unnecessary deps in reth-discv5

Blocked by a new discv5 release

@onbjerg onbjerg added S-blocked This cannot more forward until something else changes A-dependencies Pull requests or issues that are about dependencies labels Apr 30, 2024
@onbjerg onbjerg marked this pull request as draft April 30, 2024 01:29
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 22, 2024
@github-actions github-actions bot closed this May 29, 2024
@emhane emhane added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels May 29, 2024
@emhane emhane reopened this May 29, 2024
@onbjerg
Copy link
Member Author

onbjerg commented Jun 10, 2024

Still blocked 🫡

@emhane
Copy link
Member

emhane commented Jun 17, 2024

still blocked @onbjerg ?

@onbjerg
Copy link
Member Author

onbjerg commented Jun 17, 2024

yep

@onbjerg onbjerg mentioned this pull request Jun 18, 2024
Closed
@emhane
Copy link
Member

emhane commented Aug 21, 2024

what's the status here @onbjerg ?

@onbjerg
Copy link
Member Author

onbjerg commented Aug 22, 2024

still no release, so still blocked

@mattsse mattsse marked this pull request as ready for review August 28, 2024 08:50
mattsse
mattsse approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so back

@onbjerg onbjerg enabled auto-merge August 28, 2024 08:59
@onbjerg onbjerg added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 5b7d637 Aug 28, 2024
35 checks passed
@onbjerg onbjerg deleted the onbjerg/discv5-cleanup branch August 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onbjerg @emhane @mattsse @rkrasiuk @DaniPopes