chore: bump revm to latest with placeholders for EOF #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
added
S-blocked
The database should contain only analyzed bytecode, so we do not have any checked ones. We can safely use unrechable! here. |
DaniPopes
force-pushed
the
dani/revm-tmp-eof
branch
2 times, most recently
from
ec07eba to
dfe323d
Compare
This was referenced Apr 23, 2024
DaniPopes
force-pushed
the
dani/revm-tmp-eof
branch
from
0a5b560 to
e2a73b4
Compare
DaniPopes
force-pushed
the
dani/revm-tmp-eof
branch
3 times, most recently
from
3ba734b to
aff06f3
Compare
rakita
reviewed
May 11, 2024
DaniPopes
force-pushed
the
dani/revm-tmp-eof
branch
from
aff06f3 to
aa98151
Compare
DaniPopes
force-pushed
the
dani/revm-tmp-eof
branch
from
aa98151 to
3cb5064
Compare
gakonst
approved these changes
May 12, 2024
| len: buf.read_u64::<BigEndian>().unwrap() as usize, | ||
| jump_map: JumpMap::from_slice(buf), | ||
| }, | ||
| 1 => unreachable!("Junk data in database: checked Bytecode variant was removed"), |
There was a problem hiding this comment.
Is this safe to do ? Was this dead code even before?
Rjected
pushed a commit
that referenced
this pull request
May 21, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on new revm release
I don't think this requires a breaking db change, but I also don't really know how to convert a checked bytecode from db
cc @rakita