Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ChainConfig utils for block and timestamp comparisons #5978

Merged
merged 5 commits into from
Jan 9, 2024
Merged

add ChainConfig utils for block and timestamp comparisons #5978

merged 5 commits into from
Jan 9, 2024

Conversation

tcoratger
Copy link
Contributor

Description

This pull request introduces utility functions to the ChainConfig implementation, facilitating block and timestamp comparison functionalities. The added functions enable straightforward checks for blockchain activity based on specific block numbers and timestamps.

Purpose:

  • Simplifies verification of blockchain activity based on block numbers and timestamps.
  • Enhances readability and reusability of comparison logic within ChainConfig.

Rjected
Rjected requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive of additional documentation and utils, I have a few suggestions to hopefully make the docs and methods more clear and concise

crates/primitives/src/genesis.rs Outdated Show resolved Hide resolved
crates/primitives/src/genesis.rs Outdated Show resolved Hide resolved
crates/primitives/src/genesis.rs Outdated Show resolved Hide resolved
crates/primitives/src/genesis.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm!

pending @Rjected

@mattsse mattsse added the C-enhancement New feature or request label Jan 9, 2024
Rjected
Rjected approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jan 9, 2024
Merged via the queue into paradigmxyz:main with commit 7560861 Jan 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @Rjected @mattsse