Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): use alloy-rpc-types for ethereum-related types #5947

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

Evalir
Copy link
Collaborator

@Evalir Evalir commented Jan 4, 2024

Removes most eth types from the reth-rpc-types crate and uses alloy-rpc-types instead. The reth-rpc-types is still retained as we move these types outside to make the process completely transparent to reth.

This is part of the alloy transition.

@Evalir Evalir changed the title [WIP] feat(rpc): use alloy-rpc-types [WIP] feat(rpc): use alloy-rpc-types for ethereum-related types Jan 4, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, keeping the reth-rpc-types crate and use reexports instead is a good idea,

this way we can make changes to alloy and only have to change reth-rpc types

@Evalir Evalir changed the title [WIP] feat(rpc): use alloy-rpc-types for ethereum-related types feat(rpc): use alloy-rpc-types for ethereum-related types Jan 4, 2024
@mattsse mattsse added this pull request to the merge queue Jan 4, 2024
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

image

Merged via the queue into main with commit 09f04a0 Jan 4, 2024
28 checks passed
@mattsse mattsse deleted the evalir/use-alloy-rpc-types branch January 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants