refactor: move ethereum and op builder into separate crates #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
S-blocked
Merged
mattsse
added
C-debt
DaniPopes
approved these changes
Dec 28, 2023
sweet will do, this is prep for moving off op features, (soonish), feature by feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is to reduce the number of in code cfg optimism and have standalone components for different networks instead.
extracts the OP code from the basic-payload-builder and add
ethereum-payload-builder
optimimism-payload-builder
so we need less cfg optimism.
this needs a few cleanup task afterwards but should be fine for now.
Note that crates still have an optimism feature to make it easier to handle mutually exclusive payload builder crates, because clippy doesn't respect the exclude members setting from Cargo.toml
This is still a bit horrible, but at least separates the implementations.
~~blocked by #5869 ~~