fix: better conversion error handling in block_hash_ref
#5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
True, was thinking wrong, this is better now no @mattsse ? |
tcoratger
changed the title
uint_try_to method with error handling in block_hash_refblock_hash_ref
mattsse
requested changes
Dec 27, 2023
crates/revm/src/database.rs
Outdated
Comment on lines
116
to
120
| // Attempt to convert U256 to u64 | ||
| let block_number = match number.try_into() { | ||
| Ok(value) => value, | ||
| Err(_) => return Err(Self::Error::ConversionError(number)), | ||
| }; |
There was a problem hiding this comment.
wasn't there another case of try_into?
There was a problem hiding this comment.
Just found another one in the same file which is fixed now. I searched the rest of the codebase and couldn't find any others.
mattsse
added
the
C-debt
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
DaniPopes
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5864 (review)