Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PageOps metrics to libmdbx-rs #5786

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat: add PageOps metrics to libmdbx-rs #5786

merged 2 commits into from
Dec 15, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 15, 2023

This adds internal mdbx page operations to the Info struct, adding a documented PageOps struct. Some of these metrics could be included in #5691 as database metadata

@Rjected Rjected added C-enhancement New feature or request A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools labels Dec 15, 2023
onbjerg
onbjerg approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit bf37c8a Dec 15, 2023
27 checks passed
@onbjerg onbjerg deleted the dan/add-pgops-to-environment branch December 15, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @onbjerg