Json structured logs

[loocapro]

Related to: #5726.

I tried to resume all the functionalities that were a bit spread between bin/reth/src/cli/mod.rs and crates/tracing/src/lib.rs into a single component defined in crates/tracing/src/tracer.rs.

Basic usage for a json stdout tracer would be:

Tracer::new().with_stdout(LayerInfo::new(
    LogFormat::Json,
    "debug".to_string(),
    LevelFilter::INFO.into(),
    None,
));

If no layer is configured it defaults to:

impl Default for LayerInfo {
    /// Provides default values for `LayerInfo`.
    ///
    /// By default, it uses terminal format, INFO level filter,
    /// no additional filters, and no color configuration.
    fn default() -> Self {
        Self {
            format: LogFormat::Terminal,
            directive: LevelFilter::INFO.into(),
            filters: "debug".to_string(),
            color: None,
        }
    }
}

I am a bit confused on why we use log.filter and log.verbosity as cli args.

So i have included them both in the LayerInfo, but i feel like since a directive is a rule derived from a filter, I can probably get rid of one of them.

LFF (looking for feedback!) please.

CC: @shekhirin @mattsse

[mattsse]

this looks pretty good.

defer to @shekhirin and @onbjerg for a closer look

[mattsse]

friendly bump here @shekhirin @onbjerg

[shekhirin]

This looks great, just nits. Next step is integrating this into the existing logging configuration, right?

[shekhirin]

I am a bit confused on why we use log.filter and log.verbosity as cli args.

verbosity is an easy way to display all logs for a certain level without messing with RUST_LOG

[loocapro]

This looks great, just nits. Next step is integrating this into the existing logging configuration, right?

Great! Yep, I am going to proceed then!

[loocapro]

Hi @shekhirin , I have managed to hook up all components.

I have also added a Tracer trait in order to standardise the init function and remove the init_test_tracing function and just have a TestTracer struct implementing the Tracer trait. If it's ok, i can proceed to replace every init_test_tracing with the TestTracer trait.

[loocapro]

Hi @shekhirin gently bump here. I have managed to sync the code with latest main.

I have removed the TestTracer and just left the init_test_tracing function since it required a bit of changes around a lot of tests, but tell me if you want i can just do it.

I am a bit worried with dealing with more merge conflicts, so help me out here 😊

[mattsse]

ah sorry about the conflicts, we should have included this much sooner.

ptal @shekhirin

[shekhirin]

some questions on the API and overall simplification

[loocapro]

Hi @shekhirin ,

all review comments are resolved.

Keep in mind there is a slightly different behaviour than what it was before:

I have added log_stdout_filter cli arg which defaults to"info". Before the stdout EnvFilter was configured from the RUST_LOG env var and the verbosity cli arg.

Also the verbosity cli arg is only being used by the stdout layer.

Let me know if we can finally merge this.

Thanks a lot!!

[mattsse]

good to merge @shekhirin ?

[shekhirin]

@mattsse testing rn

[shekhirin]

LGTM, works as expected! Thank you for addressing all the review comments 😄

[shekhirin]

We will also need to change the CLI documentation in the book, and integrate the tracer into tests with the new RethTracer trait.

[loocapro]

LGTM, works as expected! Thank you for addressing all the review comments 😄

Thank you for your reviews!

We will also need to change the CLI documentation in the book, and integrate the tracer into tests with the new RethTracer trait.

I can take care of it.