Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the same ProviderFactory in reth node #5778

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix: use the same ProviderFactory in reth node #5778

merged 3 commits into from
Dec 15, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 15, 2023

Previously we would create new ProviderFactorys for methods like lookup_or_fetch_tip, and when building the NetworkManager in load_network_config. This now uses the existing ProviderFactory that we've already created when reth node starts

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI labels Dec 15, 2023
shekhirin
shekhirin approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo semicolons

@Rjected Rjected added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit cc4bd7c Dec 15, 2023
27 checks passed
@Rjected Rjected deleted the dan/use-provider-factory-directly branch December 15, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@shekhirin shekhirin shekhirin approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @shekhirin @onbjerg