Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add reorg metrics to grafana #5774

Merged
merged 2 commits into from
Dec 15, 2023
Merged

chore: add reorg metrics to grafana #5774

merged 2 commits into from
Dec 15, 2023

Conversation

solidoracle
Copy link
Contributor

@solidoracle solidoracle commented Dec 15, 2023 •
edited
Loading

fixes #5428

Screenshot 2023-12-15 at 12 35 47

@onbjerg onbjerg changed the title Add Reorg metrics to graphana chore: add reorg metrics to grafana Dec 15, 2023
@onbjerg onbjerg added the A-observability Related to tracing, metrics, logs and other observability tools label Dec 15, 2023
onbjerg
onbjerg requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit on this chart should not be seconds/minutes, just a simple number

onbjerg
onbjerg approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@onbjerg onbjerg added this pull request to the merge queue Dec 15, 2023
Merged via the queue into paradigmxyz:main with commit 1eaa3ed Dec 15, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorg metrics graph
2 participants
@solidoracle @onbjerg