refactor: use BlockWithSenders in executors
#5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
the
C-debt
onbjerg
requested review from
rakita,
rkrasiuk,
mattsse,
Rjected,
joshieDo,
shekhirin and
gakonst
as code owners
onbjerg
commented
Dec 15, 2023
mattsse
requested changes
Dec 15, 2023
Comment on lines
+85
to
+87
| pub fn with_recovered_senders(self) -> Option<BlockWithSenders> { | ||
| let senders = self.senders()?; | ||
| Some(BlockWithSenders { block: self, senders }) |
There was a problem hiding this comment.
should we return an Err(Self) here?
There was a problem hiding this comment.
we don't use that anywhere so doesn't make sense imo
mattsse
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the optional
sendersparameter in the executors and requires passing aBlockWithSendersinstead. Various utility functions exist on the block types to seal/unseal, provide senders and recover senders from signatures already. Since thesendersparameter already required the user to possibly handle recovering themselves, we explicitly require it now, since it makes it easier to figure out how often you recover, which is an expensive operation.See the refd issue for more info
Closes #5767