Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow no PHF or compression in snapshots #5765

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 15, 2023

If no phf was specified, the reth db snapshot was doing nothing as the cartesian product outputted the empty set.

@shekhirin shekhirin added A-cli Related to the reth CLI A-static-files Related to static files labels Dec 15, 2023
@shekhirin shekhirin marked this pull request as ready for review December 15, 2023 09:15
@shekhirin shekhirin added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 2df1e54 Dec 15, 2023
27 checks passed
@shekhirin shekhirin deleted the alexey/cli-snapshot-no-phf branch December 15, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-static-files Related to static files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants