Archify EthStateCache

[i-m-aditya]

Ref #5720

[rkrasiuk]

couple of comments:

1. We should not change provider interfaces for this purpose
2. The values should be wrapped in Arc inside lru cache itself and the Arc should only be created upon insertion
3. Having values wrapped in an Arc would require creating a custom limiter since ByLength is not implemented for Arc<Vec<T>>
4. All of the other to_vec and clone calls should become unnecessary after completion of all steps above

[i-m-aditya]

couple of comments:

1. We should not change provider interfaces for this purpose
2. The values should be wrapped in Arc inside lru cache itself and the Arc should only be created upon insertion
3. Having values wrapped in an Arc would require creating a custom limiter since ByLength is not implemented for Arc<Vec<T>>
4. All of the other to_vec and clone calls should become unnecessary after completion of all steps above

@rkrasiuk Thanks for the comments. However, I have one question:

let mut block_and_receipts = None;

        if block_id.is_pending() {
            block_and_receipts = self.provider().pending_block_and_receipts()?;
        } else if let Some(block_hash) = self.provider().block_hash_for_id(block_id)? {
            block_and_receipts = self.cache().get_block_and_receipts(block_hash).await?;
        }

For block_and_receipts to align with the same type, receipts can be Arc(as returned from the cache) or the value itself(returned from the provider). For this to happen, I need to change the provider interface. Am I missing something here?

[mattsse]

ah I see,
need to think about more, but we should proceed with simply putting the pending receipts in a new Arc before returning

[i-m-aditya]

ah I see, need to think about more, but we should proceed with simply putting the pending receipts in a new Arc before returning

Yeah, would wrap the receipt in Arc and not change the provider interface.

[mattsse]

lgtm

done