Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invert is error check #5657

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: invert is error check #5657

merged 1 commit into from
Dec 1, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 1, 2023 •
edited
Loading

bug introduced in #5404

this only checked evm errors not revert variants.

fixed by treating everything that is not ok, which is error || revert

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Dec 1, 2023
@mattsse mattsse added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit ba544d7 Dec 1, 2023
27 checks passed
@mattsse mattsse deleted the matt/invert-iserror branch December 1, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected