Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run clippy on all targets #5636

Merged
merged 4 commits into from
Nov 30, 2023
Merged

ci: run clippy on all targets #5636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1490ff
ci: run clippy on all targets
mattsse Nov 30, 2023
04f8da6
chore clippy
mattsse Nov 30, 2023
35a5602
ci: run other targets
mattsse Nov 30, 2023
6018186
ci: run other targets
mattsse Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
cache-on-failure: true
- run:
cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}"
cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --lib --tests --benches --examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--all-targets?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're testing --bin wich conflict due to optimism feature, and all-target contains --bins

env:
RUSTFLAGS: -D warnings

Expand Down
3 changes: 1 addition & 2 deletions examples/db-access.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
use reth_db::open_db_read_only;
use reth_primitives::{Address, ChainSpecBuilder, B256, U256};
use reth_primitives::{Address, ChainSpecBuilder, B256};
use reth_provider::{
AccountReader, BlockReader, BlockSource, HeaderProvider, ProviderFactory, ReceiptProvider,
StateProvider, TransactionsProvider,
};
use reth_rpc_types::{Filter, FilteredParams};
use reth_rpc_types_compat::log::from_primitive_log;

use std::path::Path;

// Providers are zero cost abstractions on top of an opened MDBX Transaction
Expand Down
Loading