Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derive job deadline from attributes timestamp #5626

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 29, 2023

ref #5623

previously we were setting a fixed 12s timeout for payload building jobs

however according to the spec:

https://github.com/ethereum/execution-apis/blob/main/src/engine/paris.md#payload-building

Client software SHOULD stop the updating process when either a call to engine_getPayload with the build process's payloadId is made or SECONDS_PER_SLOT (12s in the Mainnet configuration) have passed since the point in time identified by the timestamp parameter.

This sets the deadline as (attributes.timestamp - now) + 12s

@mattsse mattsse requested review from rkrasiuk and Rjected and removed request for Rjected November 29, 2023 17:33
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit d9ef1a1 Nov 29, 2023
27 checks passed
@mattsse mattsse deleted the matt/determine-timeout-based-on-timestamp branch November 29, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants